Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splits the two vars in research datums #6507

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Conversation

kiVts
Copy link
Contributor

@kiVts kiVts commented Jun 19, 2024

About the pull request

Splits the two vars of init argument and the behavior, should have been like that from the very start.

Explain why it's good for the game

less potential runtimes

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
code: Prevented potential unintended behavior with research upgrade items on initialize
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jun 19, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jun 19, 2024
@Drulikar Drulikar marked this pull request as draft June 19, 2024 08:11
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jun 19, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@kiVts kiVts marked this pull request as ready for review June 19, 2024 18:42
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 27, 2024
@Drulikar Drulikar added this pull request to the merge queue Jun 27, 2024
Merged via the queue into cmss13-devs:master with commit 9ecc2d5 Jun 27, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants